widget-v2 #451
Merged
widget-v2 #451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying web-sdk-react-example with
|
| Latest commit: |
b2e1fd3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://33b0d29c.web-sdk-react-example.pages.dev |
| Branch Preview URL: | https://widget-v2.web-sdk-react-example.pages.dev |
SamueleA
suggested changes
Jun 24, 2025
Contributor
There was a problem hiding this comment.
Looks good!
A few things I noticed:
- NFTs which aren't squares don't display well. We should have the square be able to display the entirety of the image of an NFT.
You can test with the following collection (if you DM me I can send you one for testing): https://polygonscan.com/token/0x631998e91476da5b870d741192fc5cbc55f5a52e
-
The explore tab of a collection doesn't seem to be doing anything. Not sure if it's incomplete or buggy. If the former, we can always remove the tab option.
-
There's a black circle over my gravatar. I'm not sure what's supposed to go there. I'm assuming it's the current network?
- I've managed to break the app, but I'm a bit unsure what is causing the issue.
Here are the steps I did:
a. in the home of the demo app, click on universal wallet and connect with a sequence wallet through facebook or google
b. open the widget, click the walet icon and click on "+ add wallet"
c. The app will crash.
d. Then, clear application data, go to the home page of the demo application, click universal wallet. The app will crash.
In my case, I was already connected to the app on localhost:4444 so it didn't go through the connect modal for universal. In other words, the two scenarios that need second view are clicking on "+ add wallet" when connected with a sequence universal wallet (not waas) and clicking the "universal wallets" option in the demo app with all application data cleared.
Contributor
Author
|
SamueleA
previously approved these changes
Jun 25, 2025
feat: added home header
feat: added homescreen tabs, feat: added modal border
refactor: removed outdated screens
feat: changed balance in home to show total balance with no filters
fix: fixed CoinRow showing price instead of fiat balance
feat: added functionality to operation popover in home screen
fix: adjusted useSettings to allow selection of multiple networks
feat: updated settings screens, feat: tweaked small ui elements, fix: clipping filter menu buttons (added horizontal scrolling)
feat: refactored loading tabs logic, feat: improved filter exit flow
refactor: combined several major components
removed unnecessary swap components
feat: added coming soon page to explore within collection details
SamueleA
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.